test: add TTY + assert test #26024
Closed
test: add TTY + assert test #26024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
cjihrig
approved these changes
Feb 10, 2019
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20713/ |
Trott
added
the
author ready
Trott
force-pushed
the
cover-tty-assert
branch
from
f38a5a5
to
25a2899
Compare
This test adds coverage for a ternary in assertion_error.js that checks if stderr is a TTY.
Trott
force-pushed
the
cover-tty-assert
branch
from
25a2899
to
8d9d083
Compare
|
Improved/clarified the test. (@cjihrig Probably worth re-reviewing.) CI: |
antsmartian
approved these changes
Feb 11, 2019
|
Still LGTM |
|
Landed in 40a8a73 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 12, 2019
This test adds coverage for a ternary in assertion_error.js that checks if stderr is a TTY. PR-URL: nodejs#26024 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 13, 2019
This test adds coverage for a ternary in assertion_error.js that checks if stderr is a TTY. PR-URL: #26024 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test adds coverage for a ternary in assertion_error.js that checks
if stderr is a TTY.
The line in question is
node/lib/internal/assert/assertion_error.js
Line 108 in e154176
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes